jonah/raytracing
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix corner bias in Vec3#random(random, true)

Browse Source
This commit is contained in:
jbb01 2024-08-08 10:22:26 +02:00
parent f7d9153ad8
commit 67bfafc5b8
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/main/java/eu/jonahbauer/raytracing/math/Vec3.java
View File

@ -17,17 +17,29 @@ public record Vec3(double x, double y, double z) {
assert Double.isFinite(x) && Double.isFinite(y) && Double.isFinite(z) : "x, y and z must be finite";
}
/**
* {@return a uniformly random vector with components in the range [-1, 1)}
*/
public static @NotNull Vec3 random(@NotNull RandomGenerator random) {
return random(random, false);
}
public static @NotNull Vec3 random(@NotNull RandomGenerator random, boolean unit) {
var vec = new Vec3(
return new Vec3(
Math.fma(2, random.nextDouble(), -1),
Math.fma(2, random.nextDouble(), -1),
Math.fma(2, random.nextDouble(), -1)
);
return unit ? vec.unit() : vec;
}
/**
* {@return a uniformly random unit vector}
*/
public static @NotNull Vec3 random(@NotNull RandomGenerator random, boolean unit) {
if (!unit) return random(random);
Vec3 vec;
double squared;
do {
vec = random(random);
squared = vec.squared();
} while (squared > 1);
return vec.div(Math.sqrt(squared));
}
public static @NotNull Vec3 reflect(@NotNull Vec3 vec, @NotNull Vec3 normal) {