jonah/raytracing
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add a check to Vec3#unit to avoid unnecessary sqrt and division

Browse Source
This commit is contained in:
jbb01 2024-08-08 21:58:51 +02:00
parent 9e79333e1e
commit 6599c41b14
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/eu/jonahbauer/raytracing/math/Vec3.java
View File

@ -270,7 +270,9 @@ public record Vec3(double x, double y, double z) {
* {@return a unit vector with the same direction as this vector} * {@return a unit vector with the same direction as this vector}
*/ */
public @NotNull Vec3 unit() { public @NotNull Vec3 unit() {
return div(length()); var squared = squared();
if (squared == 1) return this;
return div(Math.sqrt(squared));
} }
/** /**